Execution hooks #71
Merged
Execution hooks #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the Javadocs comply with changes done in bfb6696
Plugins can not be modified after registration so caching is okay.
Generally not good practice to be catching Throwable so changing to Exception.
Execution Hooks via Plugin #10
I think onComplete is clearer since the response can be either from run() or getFallback()
benjchristensen
added a commit
that referenced
this pull request
Jan 7, 2013
HystrixCommand Execution Hooks #10
|
Works great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execution Hooks via Plugin #10
A few other cleanup commits along for the ride that I did as I worked on the execution hooks.